JPEG XL

The DL link on that page had expired, but I updated it for you. It's over a week old, but I haven't made any changes since the bug fixes.

https://www.reddit.com/r/GIMP/comments/pcq7g9/jpeg_xl_gimp_plugin_for_windows/

if some kind soul feels like figuring out how to get it to build in the CI, it would be great 😄

how do you do that?

you modify `.github/workflows/release.yaml`

I can update the debian folder so that it builds the gimp plugin.

then push to your `main` branch, see if the pipeline works, get the artifact, and see if the plugin works

I'm doing that

🙂

windows, not so familiar with...

ah, I basically already have it done since I've been building on launchpad.

i just need to copy and paste. unless you're already almost done with it.

we probably want a different package though (and I need to also do it for the gdk plugin anyway)

but if you want to do `libjxl-plugin-gimp` and then I do the gdk plugin, great for me 😛

(you have been promoted to "dev", btw)

haha... do i get any perks?

recognizable color? 😛

i had been calling it gimp-jxl... is libjxl-plugin-gimp preferred?

or libjxl-gimp

I have seen that gdk plugins use XXX-gdk-pixbuf

gimp plugins look like gimp-* ... would it be better to follow the existing naming patterns or to have them all grouped together as libjxl-*

I *think* it depends on where the source comes from

if the source is in the libjxl tree, libjxl-...

otherwise, if they are in the gimp tree, gimp-...

I dunno though

but if all gimp plugins are gimp-..., then I guess we can do gimp-...

it looked to me like the gimp plugins were from all over the place, but i haven't looked closely.

i think libjxl-gimp-plugin would be fine if you're using libjxl-gdk-pixbuf

or even just libjxl-gimp

eh, that or gimp-jxl

up to you really

haha

i'll go with libjxl-gimp for now. it'll get reviewed and changed if needed.

do you know if the `debian/tmp/` part in the install files is needed for debian? on launchpad they're not.

no clue...

I assume both work

just opened a PR... will see if it builds.

So where to download the artifacts that have been mentioned?

ah, you can't from just the PR

you need to push to your own main branch

then in the pipeline runs you get the artifacts

I see... seems like a lot of resources being used up...

if people are doing their own personal builds just to get binaries.

nah, you don't need to do it that way as an user

it's just to test that it works

you can use this to get binaries locally: https://artifacts.lucaversari.it/

i.e. `deb https://artifacts.lucaversari.it/libjxl/libjxl/latest/deb/bionic /`

do you know what build scripts that site uses?

I would hope so

(lucaversari -> **luca** **ve**rsari -> ve luca -> veluca)

Actually, I have a good idea for the Gimp Windows plugin.

I just get the artefacts from github 😛

How about we convince the Windows maintainers to include it by default?

hahaha

the similarity in the names would have occurred to me eventually, i think.

Having cross platform support of JXL stuff in Gimp would easily make adoption better, especially since Action! supports capturing JXL screenshots, so there is an easy way to get JXL stuff already.

you won't get complaints from me 😛 but I think building our own doesn't hurt either

windows maintainers of gimp? the version of the plugin in the repository has some bugs that need to be fixed... I have a PR... but it needs to be updated for some recent API changes. (JxlSetBasicInfo)

https://github.com/libjxl/libjxl/pull/558 <- debian packaging for the GDK plugin

The google cla bot failed on my PR.

yeah I see that

try a `@googlebot I consent`

(in a comment)

I think it will poke it in the right way

Thanks.

can I submit?

Do i need to alert deymo for review?

nah, he reviewed already

I can approve again if need be

I made all the changes suggested and all the builds passed, so unless anything else is needed, mine is ready.

good, submitted

thanks

I'll rebase mine now

in 1~2h the artifacts thingy should be updated 🙂

the gimp plugin has some bugs though

I guess those will be fixed once we have your CL in?

This PR needs to be reviewed... https://github.com/libjxl/libjxl/pull/525

what is CL?

so every build test, all the packages are redownloaded? isn't that heavy load on the ubuntu/debian/etc servers?

Basically, make the JXL plugin for Gimp become an integral part of Gimp when it works well with all of the UI options.

CL = PR

pretty sure github has its own debian mirrors 🙂

I don't know if they are planning to accept new plugins, the GIMP 3 plugin interface is super different AFAIU

(and I don't know when GIMP 3 will be out)

I expect 2025 or later.

2.8 was released 2012-05-03. 2.10 was released 2018-10-14. So 6.5 years between releases... Next up is, 2025-03-xx

heh

I can believe that

2.10 is pretty good though. I'm pretty happy with it.

Just not going to chase after 3.0.

I reviewed it

looks like Ubuntu 18.04 does *not* have Gimp 2.10... is there a reason why we couldn't build for Gimp 2.8?

iirc, color management was very different (lacking) in 2.8

Gegl wasn't a thing either, apparently

ugh

definitely no gimp 2.8

https://ninedegreesbelow.com/photography/users-guide-to-high-bit-depth-gimp.html

> GIMP 2.9/2.10 is a radical departure from GIMP 2.8, offering: > > - New precision options for high bit depth, radiometrically correct editing. > - New color management options. > - New and corrected color space decompositions, blend modes, and conversions to black and white. > - Floating point precision with unclamped editing.

ok, no gimp plugin for 18.04 😛

I've had problems building highway for 18.04 on launchpad. Haven't looked at it carefully to figure out what the problem is.

Here's the build log: https://launchpadlibrarian.net/556401401/buildlog_ubuntu-bionic-amd64.highway_0.14.2-0xiota1_BUILDING.txt.gz

lovely

there's no "good" gtest package in 18.04

our CI installs it manually I believe

https://github.com/libjxl/libjxl/blob/main/.github/workflows/release.yaml#L179

or something like that...

That makes sense.

I've just tried it with GIMP 2.10.24 and it works pretty well. 👍 Thanks for all your Effort/Speed. 😀 I also commented on https://github.com/libjxl/libjxl/pull/525

If a user moves the Distance slider to 0, would it make sense to check the "Lossless Mode" check box automatically (and vice versa)?

Anyway, I have to say the new JXL plugin for Gimp is very good 👍

I really like it.

<@!321486891079696385> Are you using the current repository version or the Windows binaries I built?

The current repository version, as I mainly work on Linux and build from Got.

If you want, you can try out an update: https://github.com/libjxl/libjxl/pull/525

I changed it so that the lossless checkbox no longer disables the other sliders. Instead, when the slider is moved away from zero, the lossless box is unchecked. It's still possible to use distance 0 with lossless unchecked. What happens in that case is XYB is used, and file size is cut in half compared with using lossless (without XYB). (For one of my test images, 94MB vs 42MB.)

Good. And will it be understandable for the users this way?

No idea. Need users to use it to see how it goes.

Built on MSYS2 with clang.